Merged
Conversation
|
ai use disclosure is wrong, you used ai to uncomment the already existing code you're banned!! |
Collaborator
Author
|
Claude Please Generate me Fix For Something I cant Do Pls I cant Ctrl Slash Pls Help me @ Calude Pleas |
Collaborator
|
I don't necessarily see a reason as to why this shouldn't be added. But i'll leave the decision to @codeHusky. |
Collaborator
Author
|
would be nice to have for people messing with my plugin api or jsut nbt in general, it doesnt break anything and it was already apart of the codebase just commented out, i dont know if item lore was actually used in any ver of console edition, it may have been used for minigames? i never played console edition much myself outside of singleplayer so i cant say for sure |
Contributor
|
Cool fucking stone, with the best lore |
itsRevela
added a commit
to itsRevela/MinecraftConsoles
that referenced
this pull request
Mar 23, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
itsRevela
added a commit
to itsRevela/MinecraftConsoles
that referenced
this pull request
Mar 23, 2026
itsRevela
pushed a commit
to itsRevela/MinecraftConsoles
that referenced
this pull request
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This uncomments the code that allowed for displaying lore under item names.
Changes
Previous Behavior
Lore for items would not be shown under item names
Root Cause
4J made Item lore not be shown due to it not being used anywhere really, but kept the code in place just commented out.
New Behavior
Item lore now shows under item names
Fix Implementation
Uncommented the code that was commented out for Lore displaying
AI Use Disclosure
no ai